-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsonrpc): Added configuration to the RPC payload size limit #3237
Merged
nearprotocol-bulldozer
merged 2 commits into
master
from
feature/configure-rpc-payload-size-limit
Aug 25, 2020
Merged
feat(jsonrpc): Added configuration to the RPC payload size limit #3237
nearprotocol-bulldozer
merged 2 commits into
master
from
feature/configure-rpc-payload-size-limit
Aug 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
force-pushed
the
feature/configure-rpc-payload-size-limit
branch
from
August 24, 2020 15:12
f8f083e
to
3a700ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #3237 +/- ##
=======================================
Coverage 87.31% 87.31%
=======================================
Files 216 216
Lines 42153 42153
=======================================
Hits 36807 36807
Misses 5346 5346 Continue to review full report at Codecov.
|
bowenwang1996
approved these changes
Aug 24, 2020
evgenykuzyakov
approved these changes
Aug 24, 2020
nearprotocol-bulldozer
bot
deleted the
feature/configure-rpc-payload-size-limit
branch
August 25, 2020 11:14
mina86
added a commit
to mina86/nearcore
that referenced
this pull request
Sep 9, 2022
This has been deprecated at least since August 2020 (see near#3237), isn’t documented and it’s probably fair to say that anyone who cared migrated to JSON RPC requests. As a side effect, this allows us to get rid of from_base58 function.
mina86
added a commit
that referenced
this pull request
Sep 9, 2022
This has been deprecated at least since August 2020 (see #3237), isn’t documented and it’s probably fair to say that anyone who cared migrated to JSON RPC requests. As a side effect, this allows us to get rid of from_base58 function.
near-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
This has been deprecated at least since August 2020 (see #3237), isn’t documented and it’s probably fair to say that anyone who cared migrated to JSON RPC requests. As a side effect, this allows us to get rid of from_base58 function.
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
This has been deprecated at least since August 2020 (see #3237), isn’t documented and it’s probably fair to say that anyone who cared migrated to JSON RPC requests. As a side effect, this allows us to get rid of from_base58 function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3231.
The limit has been changed from 2MB to 10MB, and it is now configurable via
config.json
. This limit affects the size of the transaction, and it was hit when users deploy big contracts; with this change, we should enable deployment of contracts of up to ~6.5MB.