Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonrpc): Added configuration to the RPC payload size limit #3237

Merged

Conversation

frol
Copy link
Collaborator

@frol frol commented Aug 24, 2020

Resolves #3231.

The limit has been changed from 2MB to 10MB, and it is now configurable via config.json. This limit affects the size of the transaction, and it was hit when users deploy big contracts; with this change, we should enable deployment of contracts of up to ~6.5MB.

@gitpod-io
Copy link

gitpod-io bot commented Aug 24, 2020

@frol frol force-pushed the feature/configure-rpc-payload-size-limit branch from f8f083e to 3a700ba Compare August 24, 2020 15:12
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #3237 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3237   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files         216      216           
  Lines       42153    42153           
=======================================
  Hits        36807    36807           
  Misses       5346     5346           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e230cb...04d46dd. Read the comment docs.

@frol frol added the automerge label Aug 25, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 0401f1b into master Aug 25, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the feature/configure-rpc-payload-size-limit branch August 25, 2020 11:14
mina86 added a commit to mina86/nearcore that referenced this pull request Sep 9, 2022
This has been deprecated at least since August 2020 (see near#3237),
isn’t documented and it’s probably fair to say that anyone who
cared migrated to JSON RPC requests.

As a side effect, this allows us to get rid of from_base58 function.
mina86 added a commit that referenced this pull request Sep 9, 2022
This has been deprecated at least since August 2020 (see #3237),
isn’t documented and it’s probably fair to say that anyone who
cared migrated to JSON RPC requests.

As a side effect, this allows us to get rid of from_base58 function.
near-bulldozer bot pushed a commit that referenced this pull request Sep 9, 2022
This has been deprecated at least since August 2020 (see #3237), isn’t
documented and it’s probably fair to say that anyone who cared
migrated to JSON RPC requests.

As a side effect, this allows us to get rid of from_base58 function.
nikurt pushed a commit that referenced this pull request Nov 9, 2022
This has been deprecated at least since August 2020 (see #3237), isn’t
documented and it’s probably fair to say that anyone who cared
migrated to JSON RPC requests.

As a side effect, this allows us to get rid of from_base58 function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase RPC limit of contract deployment size
3 participants