[fix] check_balance removal under protocol feature flag
#13053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13053 +/- ##
=======================================
Coverage 69.93% 69.93%
=======================================
Files 859 859
Lines 176386 176412 +26
Branches 176386 176412 +26
=======================================
+ Hits 123350 123378 +28
- Misses 47859 47874 +15
+ Partials 5177 5160 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shreyan-gupta
added a commit
that referenced
this pull request
Mar 5, 2025
`check_balance` was converted to a debug assert in PR #12516 Unfortunately, this was a protocol change and meant old and new nodes were not in coordination any more. This PR puts `check_ balance` behind a protocol feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_balancewas converted to a debug assert in PR #12516Unfortunately, this was a protocol change and meant old and new nodes were not in coordination any more.
This PR puts
check_ balancebehind a protocol feature flag