[network] Send VersionedChunkEndorsement on T2 (#13039) #13045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With release 2.5 we had changed VersionedChunkEndorsement to be allowed on T1. This lead to a compatibility issue with 2.4 nodes, which were expecting VersionedChunkEndorsement to be allowed only on T2. To fix this problem, with release 2.5 we allow to receive VersionedChunkEndorsement on T1 but send on VersionedChunkEndorsement T2. With next release 2.6, we can start sending VersionedChunkEndorsement on T1. Zulip discussion: https://near.zulipchat.com/#narrow/channel/308695-nearone.2Fprivate/topic/2.2E5.2E0.20release.20mainnet.20-.20missing.20chunks/near/503332447
staffik
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With release 2.5 we had changed VersionedChunkEndorsement to be allowed on T1. This lead to a compatibility issue with 2.4 nodes, which were expecting VersionedChunkEndorsement to be allowed only on T2.
To fix this problem, with release 2.5 we allow to receive VersionedChunkEndorsement on T1 but send on VersionedChunkEndorsement T2.
With next release 2.6, we can start sending VersionedChunkEndorsement on T1.
Zulip discussion:
https://near.zulipchat.com/#narrow/channel/308695-nearone.2Fprivate/topic/2.2E5.2E0.20release.20mainnet.20-.20missing.20chunks/near/503332447