refactor: remove a panic in process_tx_internal by refactoring validate_tx
#13000
+48
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13000 +/- ##
==========================================
- Coverage 69.68% 69.62% -0.07%
==========================================
Files 859 859
Lines 175699 175865 +166
Branches 175699 175865 +166
==========================================
+ Hits 122435 122443 +8
- Misses 48104 48262 +158
Partials 5160 5160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wacban
approved these changes
Feb 26, 2025
| ) | ||
| .expect("no storage errors") | ||
| { | ||
| if let Err(err) = self.runtime_adapter.validate_tx( |
There was a problem hiding this comment.
Oh man the old semantics of returning Some in the error case was mad. This is a great improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we pass in the
ShardLayouttovalidate_txinstead of theEpochId, we can simplify what it returns and then remove a panic fromprocess_tx_internal.