refactoring: Speed up flipped block test #12840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyan-gupta
approved these changes
Jan 31, 2025
|
|
||
| let mid_height = 3; | ||
| for h in 1..=mid_height { | ||
| let mid_height = last_block_height + 3; |
There was a problem hiding this comment.
Can we get last_block_height from last_block.height()?
There was a problem hiding this comment.
Yes, it is possible indeed
I had to fix check_corrupt_block() to do properly process the correct block, though
There was a problem hiding this comment.
Not a biggie, only if it is convenient and straightforward
Trisfald
force-pushed
the
speed-up-test
branch
from
7098153 to
dd7c5cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12840 +/- ##
==========================================
- Coverage 70.41% 70.39% -0.02%
==========================================
Files 848 851 +3
Lines 174849 174187 -662
Branches 174849 174187 -662
==========================================
- Hits 123117 122623 -494
+ Misses 46485 46320 -165
+ Partials 5247 5244 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the test
ultra_slow_test_check_process_flipped_block_failsmore efficient by re-using the same test loop environment, instead of initializing a newTestEnvat every iteration.Locally the test runs 40% faster.