Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use correct shard_id type #12829

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

Trisfald
Copy link
Contributor

Trivial change to use the correct ShardId type

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.43%. Comparing base (57b9b81) to head (fcddcf1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12829      +/-   ##
==========================================
+ Coverage   70.41%   70.43%   +0.01%     
==========================================
  Files         848      848              
  Lines      174849   174852       +3     
  Branches   174849   174852       +3     
==========================================
+ Hits       123117   123154      +37     
+ Misses      46485    46440      -45     
- Partials     5247     5258      +11     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (?)
genesis-check 1.41% <ø> (ø)
linux 70.04% <ø> (-0.04%) ⬇️
linux-nightly 70.07% <ø> (+<0.01%) ⬆️
pytests 1.71% <ø> (+0.29%) ⬆️
sanity-checks 1.52% <ø> (?)
unittests 70.26% <ø> (-0.03%) ⬇️
upgradability 0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Trisfald Trisfald changed the title fix: use correct shard_id type chore: use correct shard_id type Jan 29, 2025
@Trisfald Trisfald marked this pull request as ready for review January 29, 2025 13:07
@Trisfald Trisfald requested a review from a team as a code owner January 29, 2025 13:07
@Trisfald Trisfald added this pull request to the merge queue Jan 29, 2025
Merged via the queue into near:master with commit 5d6105b Jan 29, 2025
29 checks passed
@Trisfald Trisfald deleted the fix-shard-id-type branch January 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants