feat(test): implement missing resharding double signing fork test #12819
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12819 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 847 847
Lines 175001 175004 +3
Branches 175001 175004 +3
=======================================
+ Hits 123338 123342 +4
- Misses 46413 46414 +1
+ Partials 5250 5248 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wacban
approved these changes
Jan 29, 2025
| @@ -80,7 +83,7 @@ pub(crate) fn fork_before_resharding_block(double_signing: bool) -> LoopAction { | |||
| base_block_height: tip.height - 1, | |||
| } | |||
| }; | |||
| client_actor.adv_produce_blocks_on(3, true, height_selection); | |||
| client_actor.adv_produce_blocks_on(blocks_produced, true, height_selection); | |||
There was a problem hiding this comment.
Why move it to an argument?
What exactly does this control? Does it have to be 3 in order to trigger fork at the right place?
There was a problem hiding this comment.
it's num of block produced
Yes it's a way to change which fork gets finalized. Small number of produced blocks -> discarded, large number -> not discarded
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slow_test_resharding_v3_double_sign_resharding_block_last_fork, to make it clearer and more accurate