Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state sync): fix fallback logic #12254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saketh-are
Copy link
Collaborator

@saketh-are saketh-are commented Oct 17, 2024

Incorrect logic was causing state sync to attempt using the fallback source even if it's None.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.61%. Comparing base (ba6c707) to head (f589ecc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12254      +/-   ##
==========================================
- Coverage   71.62%   71.61%   -0.02%     
==========================================
  Files         837      837              
  Lines      167105   167105              
  Branches   167105   167105              
==========================================
- Hits       119696   119677      -19     
- Misses      42180    42208      +28     
+ Partials     5229     5220       -9     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.25% <0.00%> (ø)
integration-tests 38.88% <100.00%> (+<0.01%) ⬆️
linux 71.22% <100.00%> (-0.02%) ⬇️
linux-nightly 71.20% <100.00%> (-0.01%) ⬇️
macos 53.70% <0.00%> (-0.61%) ⬇️
pytests 1.57% <0.00%> (ø)
sanity-checks 1.37% <0.00%> (ø)
unittests 65.42% <0.00%> (-0.02%) ⬇️
upgradability 0.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saketh-are saketh-are marked this pull request as ready for review October 18, 2024 02:08
@saketh-are saketh-are requested a review from a team as a code owner October 18, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant