-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memtrie] Simplify MemTries interface #12073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12073 +/- ##
==========================================
- Coverage 71.60% 71.58% -0.03%
==========================================
Files 816 816
Lines 164374 164337 -37
Branches 164374 164337 -37
==========================================
- Hits 117705 117645 -60
- Misses 41526 41555 +29
+ Partials 5143 5137 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
robin-near
approved these changes
Sep 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Review this PR after #12073 This PR introduces HybridArena which represents a combination of owned and shared memory. This is useful during resharding to create temporary memtries for the children of a split parent shard.
70 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review this PR after #12069
Couple of changes to the memtrie interface
get_iter
to avoid the two step process of first getting root and then iterator for memtrieload_trie_from_flat_state
functionconstruct_root
function as that was one too many layers of indirectionapply_memtrie_changes
lookup
to simplify calls to memtrie key lookups