-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing N1 S3 build bucket and OIDC #11987
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11987 +/- ##
==========================================
- Coverage 71.49% 71.49% -0.01%
==========================================
Files 810 810
Lines 164037 164037
Branches 164037 164037
==========================================
- Hits 117283 117273 -10
- Misses 41671 41674 +3
- Partials 5083 5090 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given my surface-level understanding of the specifics here. That said, some thoughts I had reading this which I think are worth writing down:
- Is N1 specific stuff really something that should live in this repository. Or said different way, if NF decides they want their own bucket, do we get a 3rd copy of scripts and workflows? What if some other entity decides they want a slice of this pie too?
- For workflows specifically duplication could be avoided with matrices.
N1 bucket is a temporary situation. Another PR will follow-up soon with more details and revert of this change. |
These workflows will build binaries and push them into n1 build bucket: n1.build.nearprotocol.com
These workflows will build binaries and push them into n1 build bucket:
n1.build.nearprotocol.com