Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing N1 S3 build bucket and OIDC #11987

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Conversation

andrei-near
Copy link
Contributor

These workflows will build binaries and push them into n1 build bucket:
n1.build.nearprotocol.com

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.49%. Comparing base (7d0e3d7) to head (919f1e9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11987      +/-   ##
==========================================
- Coverage   71.49%   71.49%   -0.01%     
==========================================
  Files         810      810              
  Lines      164037   164037              
  Branches   164037   164037              
==========================================
- Hits       117283   117273      -10     
- Misses      41671    41674       +3     
- Partials     5083     5090       +7     
Flag Coverage Δ
backward-compatibility 0.23% <ø> (ø)
db-migration 0.23% <ø> (ø)
genesis-check 1.33% <ø> (ø)
integration-tests 38.40% <ø> (-0.01%) ⬇️
linux 71.25% <ø> (-0.01%) ⬇️
linux-nightly 71.07% <ø> (+<0.01%) ⬆️
macos 54.36% <ø> (+0.01%) ⬆️
pytests 1.60% <ø> (ø)
sanity-checks 1.40% <ø> (ø)
unittests 65.58% <ø> (-0.01%) ⬇️
upgradability 0.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given my surface-level understanding of the specifics here. That said, some thoughts I had reading this which I think are worth writing down:

  1. Is N1 specific stuff really something that should live in this repository. Or said different way, if NF decides they want their own bucket, do we get a 3rd copy of scripts and workflows? What if some other entity decides they want a slice of this pie too?
  2. For workflows specifically duplication could be avoided with matrices.

@andrei-near
Copy link
Contributor Author

LGTM given my surface-level understanding of the specifics here. That said, some thoughts I had reading this which I think are worth writing down:

  1. Is N1 specific stuff really something that should live in this repository. Or said different way, if NF decides they want their own bucket, do we get a 3rd copy of scripts and workflows? What if some other entity decides they want a slice of this pie too?
  2. For workflows specifically duplication could be avoided with matrices.

N1 bucket is a temporary situation. Another PR will follow-up soon with more details and revert of this change.

@andrei-near andrei-near added this pull request to the merge queue Aug 23, 2024
Merged via the queue into master with commit f3617a0 Aug 23, 2024
29 of 30 checks passed
@andrei-near andrei-near deleted the N1-build-bucket-releases branch August 23, 2024 05:49
andrei-near added a commit that referenced this pull request Aug 23, 2024
The build bucket was moved to N1 org and we need to adjust credentials.
Switching to OIDC for mac release workflow.
Removing N1 temporary build buckets
jancionear pushed a commit that referenced this pull request Aug 26, 2024
These workflows will build binaries and push them into n1 build bucket:
n1.build.nearprotocol.com
jancionear pushed a commit that referenced this pull request Aug 26, 2024
The build bucket was moved to N1 org and we need to adjust credentials.
Switching to OIDC for mac release workflow.
Removing N1 temporary build buckets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants