Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ft-benchmark] remove lock file after successful run #11834

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

MCJOHN974
Copy link
Contributor

Of course we want remove lock after a successful run, not only after fails during benchmark execution

@MCJOHN974 MCJOHN974 requested a review from aborg-dev July 24, 2024 02:55
@MCJOHN974 MCJOHN974 requested a review from a team as a code owner July 24, 2024 02:55
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (ad0647b) to head (aabb5a6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11834      +/-   ##
==========================================
- Coverage   71.81%   71.79%   -0.03%     
==========================================
  Files         796      796              
  Lines      163333   163333              
  Branches   163333   163333              
==========================================
- Hits       117302   117261      -41     
- Misses      40975    41020      +45     
+ Partials     5056     5052       -4     
Flag Coverage Δ
backward-compatibility 0.23% <ø> (ø)
db-migration 0.23% <ø> (ø)
genesis-check 1.35% <ø> (ø)
integration-tests 37.78% <ø> (-0.04%) ⬇️
linux 71.55% <ø> (-0.03%) ⬇️
linux-nightly 71.36% <ø> (-0.02%) ⬇️
macos 54.68% <ø> (-0.02%) ⬇️
pytests 1.62% <ø> (ø)
sanity-checks 1.42% <ø> (ø)
unittests 66.24% <ø> (-0.11%) ⬇️
upgradability 0.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MCJOHN974 MCJOHN974 added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit 7cfe89a Jul 24, 2024
30 checks passed
@MCJOHN974 MCJOHN974 deleted the viktar/ft-benchmark-fix branch July 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants