[ft-benchmark] benchmarknet #11826
[ft-benchmark] benchmarknet #11826
Conversation
core/primitives-core/src/chains.rs
Outdated
| @@ -11,3 +11,6 @@ pub const STATELESSNET: &str = "statelessnet"; | |||
|
|
|||
| /// Pre-release testing environment. | |||
| pub const MOCKNET: &str = "mocknet"; | |||
|
|
|||
| /// Used by ft-benchmark. TODO: Put link to ft-benchmark docs. | |||
There was a problem hiding this comment.
You can use http://go/crt-benchmark as a link here.
core/parameters/src/config_store.rs
Outdated
| near_primitives_core::chains::BENCHMARKNET => { | ||
| let mut config_store = Self::new(None); | ||
| let mut config = RuntimeConfig::clone(config_store.get_config(PROTOCOL_VERSION)); | ||
| config.congestion_control_config.max_tx_gas = 10u64.pow(8); |
There was a problem hiding this comment.
I think a good value for max and min gas would be 100 PGas, so higher than the current value.
There was a problem hiding this comment.
Actually, we can also use an old "unlimited" value: 9_223_372_036_854_775_807
There was a problem hiding this comment.
Btw I seen high tps on gcp without changing this values
| @@ -136,6 +138,18 @@ impl RuntimeConfigStore { | |||
| let genesis_runtime_config = RuntimeConfig::initial_testnet_config(); | |||
| Self::new(Some(&genesis_runtime_config)) | |||
| } | |||
| near_primitives_core::chains::BENCHMARKNET => { | |||
There was a problem hiding this comment.
We need to add a detailed comment here:
// In benchmarknet, we are measuring the peak throughput that the NEAR network can handle while still being stable.
// This requires increasing the limits below that are set too conservatively.
| @@ -130,12 +132,26 @@ impl RuntimeConfigStore { | |||
| /// first protocol versions. | |||
There was a problem hiding this comment.
The line 131 got out of date, it needs to include "except testnet and benchmarknet"
There was a problem hiding this comment.
It says "for first protocol versions" while we are overriding only last.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11826 +/- ##
==========================================
+ Coverage 71.80% 71.82% +0.02%
==========================================
Files 796 796
Lines 163200 163216 +16
Branches 163200 163216 +16
==========================================
+ Hits 117182 117232 +50
+ Misses 40973 40947 -26
+ Partials 5045 5037 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MCJOHN974
force-pushed
the
akashin/benchmark_override
branch
from
e8cb966 to
2ed14a6
Compare
No description provided.