Unconditionally enable SHA-NI extensions #11711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on this extension to accelerate computation of SHA2 hashes quickly. This extension not being present will slow down node beyond what's reasonable and the node will not be able to keep up with others. Enabling this extension unconditionally and having the node fail early on machines where the extension is not available seems like a reasonable option here.
akhi3030
approved these changes
Jul 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11711 +/- ##
==========================================
+ Coverage 70.19% 70.22% +0.02%
==========================================
Files 791 791
Lines 161937 161937
Branches 161937 161937
==========================================
+ Hits 113671 113715 +44
+ Misses 43298 43257 -41
+ Partials 4968 4965 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
If they are running without SHA-NI, their node is pretty slow and with stateless this problem would likely get exacerbated to the point where the node cannot keep up with the network at all (if it is still able to right now.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on this extension to accelerate computation of SHA2 hashes quickly. This extension not being present will slow down node beyond what's reasonable and the node will not be able to keep up with others. Enabling this extension unconditionally and having the node fail early on machines where the extension is not available seems like a reasonable option here.