Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS release workflow: no store validator #11709

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

andrei-near
Copy link
Contributor

@andrei-near andrei-near commented Jul 3, 2024

we don't build store validator on neard release anymore and wf upload is failing https://github.com/near/nearcore/actions/runs/9765365593/job/26955860213

@andrei-near andrei-near requested a review from a team as a code owner July 3, 2024 08:36
@andrei-near andrei-near requested a review from tayfunelmas July 3, 2024 08:36
@andrei-near andrei-near enabled auto-merge July 3, 2024 08:37
@andrei-near andrei-near disabled auto-merge July 3, 2024 08:39
@andrei-near andrei-near enabled auto-merge July 3, 2024 08:42
@andrei-near andrei-near added this pull request to the merge queue Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.23%. Comparing base (ced534f) to head (fcdc1a0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11709      +/-   ##
==========================================
+ Coverage   70.19%   70.23%   +0.03%     
==========================================
  Files         791      791              
  Lines      161937   161937              
  Branches   161937   161937              
==========================================
+ Hits       113671   113729      +58     
+ Misses      43298    43246      -52     
+ Partials     4968     4962       -6     
Flag Coverage Δ
backward-compatibility 0.23% <ø> (ø)
db-migration 0.23% <ø> (ø)
genesis-check 1.35% <ø> (ø)
integration-tests 37.97% <ø> (+<0.01%) ⬆️
linux 69.98% <ø> (+0.01%) ⬆️
linux-nightly 69.79% <ø> (-0.03%) ⬇️
macos 54.62% <ø> (+1.69%) ⬆️
pytests 1.58% <ø> (ø)
sanity-checks 1.38% <ø> (ø)
unittests 64.51% <ø> (+0.04%) ⬆️
upgradability 0.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrei-near andrei-near removed this pull request from the merge queue due to a manual request Jul 3, 2024
@andrei-near andrei-near added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 9a41e3e Jul 3, 2024
30 checks passed
@andrei-near andrei-near deleted the mac-os-release--no-store-validator branch July 3, 2024 09:24
marcelo-gonzalez pushed a commit to marcelo-gonzalez/nearcore that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants