-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Have real epoch_manager as default for tests #10598
[test] Have real epoch_manager as default for tests #10598
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10598 +/- ##
==========================================
- Coverage 72.05% 72.02% -0.03%
==========================================
Files 725 725
Lines 147195 147183 -12
Branches 147195 147183 -12
==========================================
- Hits 106054 106013 -41
- Misses 36294 36313 +19
- Partials 4847 4857 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, this is simply a small renaming with many occurrences, from what I see
Yep! Now we can focus on getting rid of these calls to mock_epoch_manager |
In an effort to kill mock epoch manager, this PR makes the default test environment have real epoch managers.
All tests that still do require a mock epoch manager (for whatever reason), can call
builder.mock_epoch_managers()
.Over time we would slowly like to get rid of all calls to
mock_epoch_managers()