Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Have real epoch_manager as default for tests #10598

Merged
merged 11 commits into from
Feb 12, 2024

Conversation

shreyan-gupta
Copy link
Contributor

@shreyan-gupta shreyan-gupta commented Feb 9, 2024

In an effort to kill mock epoch manager, this PR makes the default test environment have real epoch managers.

All tests that still do require a mock epoch manager (for whatever reason), can call builder.mock_epoch_managers().

Over time we would slowly like to get rid of all calls to mock_epoch_managers()

Base automatically changed from shreyan/test/real_epoch_managers to master February 9, 2024 19:00
@shreyan-gupta shreyan-gupta marked this pull request as ready for review February 9, 2024 22:35
@shreyan-gupta shreyan-gupta requested a review from a team as a code owner February 9, 2024 22:35
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c6afdd7) 72.05% compared to head (d3b7ae9) 72.02%.

Files Patch % Lines
chain/client/src/test_utils/test_env_builder.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10598      +/-   ##
==========================================
- Coverage   72.05%   72.02%   -0.03%     
==========================================
  Files         725      725              
  Lines      147195   147183      -12     
  Branches   147195   147183      -12     
==========================================
- Hits       106054   106013      -41     
- Misses      36294    36313      +19     
- Partials     4847     4857      +10     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (+<0.01%) ⬆️
db-migration 0.08% <0.00%> (+<0.01%) ⬆️
genesis-check 1.25% <0.00%> (+<0.01%) ⬆️
integration-tests 37.06% <54.54%> (-0.08%) ⬇️
linux 71.07% <90.90%> (+<0.01%) ⬆️
linux-nightly 71.46% <90.90%> (-0.05%) ⬇️
macos 55.02% <90.90%> (+0.01%) ⬆️
pytests 1.46% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.26% <0.00%> (+<0.01%) ⬆️
unittests 67.92% <90.90%> (-0.02%) ⬇️
upgradability 0.13% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, this is simply a small renaming with many occurrences, from what I see

@shreyan-gupta
Copy link
Contributor Author

Makes sense, this is simply a small renaming with many occurrences, from what I see

Yep! Now we can focus on getting rid of these calls to mock_epoch_manager

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Feb 12, 2024
Merged via the queue into master with commit 61cec49 Feb 12, 2024
27 of 28 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/test/real_epoch_manager_default branch February 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants