Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] real_epoch_managers doesn't need genesis.config #10597

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

shreyan-gupta
Copy link
Contributor

@shreyan-gupta shreyan-gupta commented Feb 9, 2024

Buildup PRs

#10590
#10591
#10594

Next PR I'll try using the real epoch manager as default and let's see what happens...

@shreyan-gupta shreyan-gupta changed the title [test] Refactor real_epoch_managers [test] real_epoch_managers doesn't need genesis.config Feb 9, 2024
@shreyan-gupta shreyan-gupta marked this pull request as ready for review February 9, 2024 16:09
@shreyan-gupta shreyan-gupta requested a review from a team as a code owner February 9, 2024 16:09
@akhi3030 akhi3030 removed their request for review February 9, 2024 16:14
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c34e92) 72.05% compared to head (0da738a) 72.02%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10597      +/-   ##
==========================================
- Coverage   72.05%   72.02%   -0.04%     
==========================================
  Files         725      725              
  Lines      147196   147195       -1     
  Branches   147196   147195       -1     
==========================================
- Hits       106067   106019      -48     
- Misses      36284    36322      +38     
- Partials     4845     4854       +9     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (ø)
db-migration 0.08% <0.00%> (ø)
genesis-check 1.25% <0.00%> (+<0.01%) ⬆️
integration-tests 37.07% <60.00%> (-0.07%) ⬇️
linux 71.05% <100.00%> (+0.04%) ⬆️
linux-nightly 71.47% <100.00%> (-0.06%) ⬇️
macos 55.01% <100.00%> (-0.06%) ⬇️
pytests 1.46% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.26% <0.00%> (+<0.01%) ⬆️
unittests 67.93% <100.00%> (-0.01%) ⬇️
upgradability 0.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Feb 9, 2024
Merged via the queue into master with commit c6afdd7 Feb 9, 2024
27 of 28 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/test/real_epoch_managers branch February 9, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants