Fix: get branch on RELEASE event triggered workflow #10495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-near
changed the title
Ekleog-NEAR
reviewed
Jan 25, 2024
posvyatokum
approved these changes
Jan 25, 2024
This would need to be merged into 1.37 branch as well. Only then the triggered WF would function correctly. |
Done this yesterday, binary is published and already released |
we could in the workflow but still need to adjust the binary release bash script because context vars are not passed to it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10495 +/- ##
==========================================
+ Coverage 71.99% 72.01% +0.02%
==========================================
Files 720 720
Lines 146328 146328
Branches 146328 146328
==========================================
+ Hits 105343 105385 +42
+ Misses 36132 36100 -32
+ Partials 4853 4843 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
posvyatokum
pushed a commit
that referenced
this pull request
Jan 29, 2024
On release triggered workflow runs, the HEAD is detached and no local branch is present. Due to this, BRANCH var ends up as an empty string and this causes failures to publish artifacts: https://github.com/near/nearcore/actions/runs/7640475082/job/20815674136 ++ git branch --show-current + BRANCH= ++ git rev-parse HEAD + COMMIT=c869dd6c1e942f21e27a74c7e47a698de ++ uname this leads to incorrect S3 paths: `s3://build.nearprotocol.com/nearcore/$(uname)/${BRANCH}/latest` -> `s3://build.nearprotocol.com/nearcore/Linux//latest`
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
#10495 was meant to fix the builds triggered by release events. With actions/checkout GHA action only a single commit is fetched by default and thus missing branch match. To fetch all history for all branches and tags, setting fetch-depth to 0 for both binary and docker image release jobs. This was [tested](https://github.com/near/andrei-playground/actions/runs/7696882172/job/20972653224) on a private repo. <img width="676" alt="Screenshot 2024-01-29 at 13 42 09" src="https://github.com/near/nearcore/assets/122784628/941c1cd8-285e-4853-a9e7-a6ea6885c838">
posvyatokum
pushed a commit
that referenced
this pull request
Jan 30, 2024
#10495 was meant to fix the builds triggered by release events. With actions/checkout GHA action only a single commit is fetched by default and thus missing branch match. To fetch all history for all branches and tags, setting fetch-depth to 0 for both binary and docker image release jobs. This was [tested](https://github.com/near/andrei-playground/actions/runs/7696882172/job/20972653224) on a private repo. <img width="676" alt="Screenshot 2024-01-29 at 13 42 09" src="https://github.com/near/nearcore/assets/122784628/941c1cd8-285e-4853-a9e7-a6ea6885c838">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On release triggered workflow runs, the HEAD is detached and no local branch is present.
Due to this, BRANCH var ends up as an empty string and this causes failures to publish artifacts:
https://github.com/near/nearcore/actions/runs/7640475082/job/20815674136
++ git branch --show-current
++ git rev-parse HEAD
++ uname
this leads to incorrect S3 paths:
s3://build.nearprotocol.com/nearcore/$(uname)/${BRANCH}/latest->s3://build.nearprotocol.com/nearcore/Linux//latest