-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stateless_validation] Refactor all tests to handle ChunkStateWitness and ChunkEndorsement network messages #10508
Comments
What's the current status? |
@shreyan-gupta is this needed for MVP? |
Is this still an issue after the new chunk witness distribution work? does the distribution logic has the same shortcoming in tests? I am interested in learning the details of this issue. |
confirmed with @shreyan-gupta that this is not needed for MVP |
This is actually quite an old issue from Jan. This was for when I had originally implemented the ChunkEndorsement logic for state validation, we didn't have a great way to test out the feature with multiple nodes. Since then we have invested time in framework like TestLoop to get a set of reliable tests for end to end scenarios. Meanwhile we've also written custom handlers (and tests) for the normal test framework as well. I guess we can close this issue. |
Handling single client tests with stateless validation is currently very difficult as we don't have good ways to deal with the network messages to send the chunk state witness and chunk endorsements.
As a temporary solution, we're calling
process_chunk_endorsement
bypassing the network stack for single client settings.More context in this comment: #10501 (comment)
The text was updated successfully, but these errors were encountered: