Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App login: display contract ID #2276

Merged
merged 2 commits into from
Dec 1, 2021
Merged

App login: display contract ID #2276

merged 2 commits into from
Dec 1, 2021

Conversation

Patrick1904
Copy link
Contributor

@Patrick1904 Patrick1904 commented Nov 30, 2021

Screen Shot 2021-11-30 at 1 34 00 PM

@render
Copy link

render bot commented Nov 30, 2021

Copy link
Contributor

@MaximusHaximus MaximusHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lookin' good, thanks for the quick work! :)

@@ -26,8 +40,14 @@ const StyledContainer = styled.div`
}
`;

export default () => (
export default ({ contractId, contractIdUrl }) => (
Copy link
Contributor

@MaximusHaximus MaximusHaximus Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but we should probably rename this thing to e.g. LoginRequestDetails now that it's not really specific to the Network Fee Allowance...

@MaximusHaximus MaximusHaximus merged commit 64cbb4f into master Dec 1, 2021
@MaximusHaximus MaximusHaximus deleted the issue-2275 branch December 1, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login UI should always display both the target contract ID and the referrer of the login request
2 participants