Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the returned type of the includeBytes function from string to Uin… #355

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix the returned type of the includeBytes function from string to Uin… #355

merged 1 commit into from
Apr 26, 2023

Conversation

nsejim
Copy link
Contributor

@nsejim nsejim commented Apr 25, 2023

…t8Array

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

@nsejim nsejim requested review from ailisp and volovyks as code owners April 25, 2023 04:24
@nsejim nsejim force-pushed the bugfix/update-ts-definition-for-include-bytes-method branch from 42b78ac to b814461 Compare April 25, 2023 20:32
@nsejim
Copy link
Contributor Author

nsejim commented Apr 25, 2023

Executed npm run build to also update generated .d.ts files

@ailisp
Copy link
Member

ailisp commented Apr 26, 2023

@nsejim Looks great. Thank you!

@ailisp ailisp merged commit 01cab6d into near:develop Apr 26, 2023
@nsejim nsejim deleted the bugfix/update-ts-definition-for-include-bytes-method branch April 27, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailisp ailisp ailisp approved these changes

@volovyks volovyks Awaiting requested review from volovyks volovyks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsejim @ailisp