Cross platform post-install #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ailisp do you know what is happening with our CI? It has not started... |
|
I also can't see reason why it doesn't. Can be github action scheduler's issue? Let me try close and reopen |
|
Started this time. Weird |
ailisp
approved these changes
Oct 20, 2022
ailisp
reviewed
Oct 20, 2022
|
|
||
| const OS = await executeCommand("uname -s", false); | ||
| const ARCH = await executeCommand("uname -m", false); | ||
| const SUPPORTED_PLATFORMS = ["linux", "darwin"]; // Unsaported platforms: 'win32', 'aix', 'freebsd', 'openbsd', 'sunos', 'android' |
There was a problem hiding this comment.
Oh, changes below are made for windows support, but there's still some part of the build process that doesn't support windows. Am I right?
There was a problem hiding this comment.
It's just part of the effort. So Windows is not on the list just yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash approach does not work on Windows