-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NEP-455: storage compute costs for v61 #477
Conversation
@jakmeier Could you provide some references to the prior discussions, and ideally update everyone on the reasoning for the change? 🙏 |
So far, I wrote down a summary in the linked tracking issue. near/nearcore#8938 Would you like to see more details pulled into the NEP itself? Also, do you think the table I added contains the relevant information? So far it's just a quick draft I came up with and I am happy to change it to a format that is more useful to readers. |
@jakmeier I wish all the details are summarized into the document instead of expecting readers to follow an external link and collect information bit by bit. |
@jakmeier testnet release has been cut, is it ready to review? https://github.com/near/nearcore/releases/tag/1.34.0-rc.1 |
@frol sorry for the delay on this. This is now ready for review. Please let me know if it is detailed enough. The change is now released to mainnet validators and the protocol change will take effect after voting on protocol version 61 succeeds, earliest possible date is 2023-06-12 15:00 UTC. |
As a moderator, I take all the reviews put into nearcore implementation as the SME review stage and ask @near/wg-protocol to vote on this NEP (it seems like it should be a quick 👍), and we are good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bowenwang1996 mentioned offline that it is a minor update to reflect the state of things, so there is no need to require votes from other WG members. So I am merging it.
Tracks the newly introduced compute costs for protocol version 61.
(draft: the changes are still being merged in, I plan to mark this PR ready for review once the testnet release has been cut and confirmed to include the relevant compute cost values.)