Updated Backbone.Validations to work with Backbone 0.9.10 #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backbone 0.9.10 has some fairly big changes to validation, though the changes to Backbone.Validations are confined to the
newPerformValidation
functionI've just made it re-use the default
Backbone._validate
function instead of re-implementing it, to save some hassle. Some extra work is required to raiseinvalid:prop
events, you wouldn't have to override_validate
at all if it didn't have to raise these..For reference, the new behaviour is as follows:
invalid
events are now raised for validation errors aserror
is now reserved for xhr errors (this is badly documented but the correct behaviour: Failed validation does not trigger error callback jashkenas/backbone#2153)set
, call with {validate: true} (I had to update the unit tests)error
callback is not called on validation errors, you can inspect themodel.validationError
property instead, immediately after callingsave