Prevent invalid 'required' field being saved to model if its already set... #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set value is not undefined.
|
modify/add tests and we're good. |
… corrected from 'maxlength' to 'minlength'.
|
I added check to be sure attempt to save 'undefined' value will result in appropriate error and won't be saved for required field. |
nealstewart
pushed a commit
that referenced
this pull request
Oct 3, 2012
…d_value Prevent invalid 'required' field being saved to model if its already set...
|
Thanks for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation enables invalid required field value being saved to model if its already set value is not undefined.
1 var currentValue = model.get(attributeName);
2 var isNotAlreadySet = _ .isUndefined(currentValue);
3 var isNotBeingSet = _ .isUndefined(valueToSet);
4 if (_.isNull(valueToSet) || valueToSet === "" || (isNotBeingSet && isNotAlreadySet)) {
This means, attempt to save 'undefined' value will be successful despite the fact error will be eventually generated and shown.
This very small fix will help to overcome the problem and make validation for required field work as expected.