fix: address kakoune edge cases (builtin docs + diagnostics) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed builtin docs such that external commands are not formatted with `https://fishshell.com/docs/current/cmds/link.html` header. Relevant change occurred in [./src/utils/documentation-cache.ts](./src/utils/documentation-cache.ts) * Fix diagnostics for conditional `if/else if` syntax blocks which do not require `-q/--query/--quiet` flag ```fish if set fishpath (status fish-path) echo "fishpath is set: $fishpath" end ``` * Extend conditional `if/else if` command support for all default commands shipped with fish shell, that can be used as a conditional expression. * Updated [./scripts/build-completions.fish](./scripts/build-completions.fish) to use `$fish_complete_path` environment variable to generate * Refactored `logger` from [./src/logger.ts](./src/logger.ts) to export a single instance of `Logger` class, and use it throughout the codebase. * Added testing for changes towards diagnostic behavior in [./test-data/diagnostics.test.ts](./test-data/diagnostics.test.ts) See bug report [here](kakoune-lsp/kakoune-lsp#809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fishshell.com/docs/current/cmds/link.htmlheader. Relevant change occurred in ./src/utils/documentation-cache.tsif/else ifsyntax blocks which do not require-q/--query/--quietflagif/else ifcommand support for all default commands shipped with fish shell, that can be used as a conditional expression.$fish_complete_pathenvironment variable to generateloggerfrom ./src/logger.ts to export a single instance ofLoggerclass, and use it throughout the codebase.See bug report here