Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip over CDATA #17

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Skip over CDATA #17

merged 2 commits into from
Aug 25, 2024

Conversation

mniip
Copy link
Contributor

@mniip mniip commented Jul 8, 2024

Addresses #1

  • Don't fail the parse if we run into a CDATA.
  • Do the same to CDATA as we do to comments: leave it up to the downstream user to parse them.

@mniip
Copy link
Contributor Author

mniip commented Jul 16, 2024

@ndmitchell gentle prod?

@ndmitchell
Copy link
Owner

Thanks for the patch. I reviewed it by eye and it looks great. Can we get a test in https://github.com/ndmitchell/hexml/blob/master/src/Main.hs as well? It's pretty subtle doing this coding, and a test would give a lot of confidence.

I'm afraid I'm going to be too busy to land over the next 2 weeks, but will endeavor to do it when I'm free again after that.

@mniip
Copy link
Contributor Author

mniip commented Aug 23, 2024

@ndmitchell ping?

@ndmitchell ndmitchell merged commit f4c36c1 into ndmitchell:master Aug 25, 2024
0 of 8 checks passed
@ndmitchell ndmitchell mentioned this pull request Aug 25, 2024
@ndmitchell
Copy link
Owner

Thanks! I released Hexml 0.3.5 with this change.

@mniip mniip deleted the cdata branch November 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants