Do not attempt to read data if no data is left #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where data is attempted to be read from the ssh-agent pipe, but no data is actually available.
Some background information on how I discovered and fixed this issue:
I am using winssh-pageant in combination with KeePass and KeeAgent.
KeeAgent works in Pageant client mode and adds SSH keys stored in KeePass.
The keys were being added, however it caused KeePass to hang for about 60 seconds, after investigation I found that the code tried to read data, even though no data was available.
I added a check to skip reading data if no more data was available and it works fine for me now.