Add some improvments for handling the response body#192
Merged
ncw merged 1 commit intoncw:masterfrom Feb 4, 2026
Merged
Conversation
In v.2.0.5 the response body is now appended to the error. However, there are two possible improvements to this code. Firstly, if the response body reader returned io.EOF we would not append the response body. Secondly, it's difficult to extract the response body from the error when it's simply wrapped. Instead we will now return an ErrorWithBody. Change-Id: I21b3001a001a2cacf3be4a767f89987b9b829530
ncw
approved these changes
Feb 4, 2026
Owner
ncw
left a comment
ncw
left a comment
There was a problem hiding this comment.
Nice change, thank you.
Will merge now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v.2.0.5 the response body is now appended to the error. However, there are two possible improvements to this code. Firstly, if the response body reader returned io.EOF we would not append the response body. Secondly, it's difficult to extract the response body from the error when it's simply wrapped. Instead we will now return an ErrorWithBody.
Change-Id: I21b3001a001a2cacf3be4a767f89987b9b829530