Fix races related to the way how authLock is implemented and used#170
Merged
ncw merged 3 commits intoncw:masterfrom Oct 6, 2021
yuri-per:master
Merged
Fix races related to the way how authLock is implemented and used#170ncw merged 3 commits intoncw:masterfrom yuri-per:master
ncw merged 3 commits intoncw:masterfrom
yuri-per:master
Conversation
Previously when Authenticate() or Authenticated() was called simultaneously from several goroutines authLock was initialized in racy manner. Such code is not allowed by Go Memory Model and sometimes crashes.
Access to StorageUrl without taking authLock is racy. New method GetStorageUrl() is added for getting StorageLock in race-free manner. Methods where StorageUrl was accessed without lock (QueryInfo() and ObjectTempUrl()) are updated.
This change is required to pass CI tests.
ncw
approved these changes
Oct 6, 2021
Owner
ncw
left a comment
ncw
left a comment
There was a problem hiding this comment.
This looks great - thank you for fixing this up.
I wrote this code when I was a go n00b and now you've pointed it out it is horrible, so thank you for fixing it.
I'll merge this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Allocate authLock as part of Connection
Previously when Authenticate() or Authenticated() was called simultaneously from several goroutines authLock was initialized in racy manner. Such code is not allowed by Go Memory Model and sometimes crashes.
2. Introduce GetStorageUrl() method
Access to StorageUrl without taking authLock is racy. New method GetStorageUrl() is added for getting StorageLock in race-free manner. Methods where StorageUrl was accessed without lock (QueryInfo() and ObjectTempUrl()) are updated.