Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft WCS vignette #290

Merged
merged 8 commits into from
Jun 9, 2023
Merged

Add draft WCS vignette #290

merged 8 commits into from
Jun 9, 2023

Conversation

brownag
Copy link
Member

@brownag brownag commented May 3, 2023

based on @dylanbeaudette's tutorial http://ncss-tech.github.io/AQP/soilDB/WCS-demonstration-01.html
for #263

TODO:

  • figure margins
  • other aesthetics (maintain low dependencies; no rasterVis, lattice or color palette packages)
  • harmonize approaches and specification of coordinate reference system? Consider using "OGC:CRS84" and not using bare integer codes e.g. "EPSG:5070" rather than 5070
  • link out to get_SDA*() function specific vignette for better detail on tabular data acquisition
  • use hcl.colors() from {grDevices} instead of viridis::viridis()
  • use get_SDV_legend_elements() for interpretation thematic map colors and labels

A couple things I noticed... not causing issues internally, but may cause confusion for users. Dylan mentioned ordered factor issue recently and now I experienced it with some of the examples i.e. Concrete Corrosion.

  • investigate ordered factor level preservation in RAT?
  • investigate join of character values to RAT using levels<- v.s. replacement of RAT

@brownag brownag marked this pull request as ready for review June 7, 2023 16:48
@brownag
Copy link
Member Author

brownag commented Jun 7, 2023

  • link out to get_SDA*() function specific vignette for better detail on tabular data acquisition

will be addressed in future part of #157

@brownag
Copy link
Member Author

brownag commented Jun 7, 2023

  • Opting to not use hcl.colors().
  • Investigated ordered factor level preservation and it is non-trivial to implement, though within in-memory terra objects it is technically feasible

@brownag
Copy link
Member Author

brownag commented Jun 7, 2023

For some reason this PR is not updating. There are 2 more recent commits on this branch, for a total of 5, including a merge commit updating w/ recent changes on masterEverything seems to be in sync now, ready for review

@brownag
Copy link
Member Author

brownag commented Jun 9, 2023

Merging after discussion w/ @dylanbeaudette; this is functional but will be revised further in coming weeks/after new vignettes are added

@brownag brownag merged commit 42c0e3a into master Jun 9, 2023
@brownag brownag deleted the wcs-ssurgo-vignette branch September 1, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant