Conversation
Owner
Author
|
Seems I'm convinced. 🙂 |
|
nice work on this by the way! decreased ffmpeg source code output from 180MB down to 130MB :) |
Owner
Author
|
Also I did forget your suggestion for a CLI flag, but I'll probably add one. I think "reverting" this is just a matter of having That's useful if we ever suspect a bug due to this. |
Owner
Author
|
The latest version adds a few more "passes" to the optimization pipeline, and results in another 10% reduction for me. |
|
oh very nice! I haven't been at the computer in a few days due to moving house, but when I'm back I'll be sure to regenerate and see how it looks 👀 |
Owner
Author
|
Even lazier now. With these I think I've gone from 600k lines for SQLite to less than 200k. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to keep "pure" values unevaluated in the stack.
It generates denser code, which helps the Go compiler (generated code compiles faster, produces smaller binaries).
The problem is convincing myself the optimization is correct.