Skip to content

Conversation

@Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Mar 14, 2017

Without this change:

which: no scanelf in (~/bin:/opt/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin)
ls => /bin/ls (interpreter => /lib64/ld-linux-x86-64.so.2)
    libselinux.so.1 => /lib64/libselinux.so.1
        libpcre.so.1 => /lib64/libpcre.so.1
            libpthread.so.0 => /lib64/libpthread.so.0
        libdl.so.2 => /lib64/libdl.so.2
    libcap.so.2 => /lib64/libcap.so.2
        libattr.so.1 => /lib64/libattr.so.1
    libacl.so.1 => /lib64/libacl.so.1
    libc.so.6 => /lib64/libc.so.6

With this change:

ls => /bin/ls (interpreter => /lib64/ld-linux-x86-64.so.2)
    libselinux.so.1 => /lib64/libselinux.so.1
        libpcre.so.1 => /lib64/libpcre.so.1
            libpthread.so.0 => /lib64/libpthread.so.0
        libdl.so.2 => /lib64/libdl.so.2
    libcap.so.2 => /lib64/libcap.so.2
        libattr.so.1 => /lib64/libattr.so.1
    libacl.so.1 => /lib64/libacl.so.1
    libc.so.6 => /lib64/libc.so.6

lddtree.sh Outdated
${SET_X} && set -x

if which scanelf >/dev/null; then
if which scanelf &>/dev/null; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the &>/dev/null is bashism and not POSIX shell. We should probably do >/dev/null 2>&1

lddtree.sh Outdated
if which scanelf &>/dev/null; then
BACKEND=scanelf
elif which objdump >/dev/null && which readelf >/dev/null; then
elif which objdump &>/dev/null && which readelf &>/dev/null; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Change to >/dev/null 2>&1

@Luthaf
Copy link
Contributor Author

Luthaf commented Mar 14, 2017

Done !

@Luthaf
Copy link
Contributor Author

Luthaf commented Mar 20, 2017

ping ?

@ncopa ncopa merged commit 61d105a into ncopa:master Mar 22, 2017
@Luthaf Luthaf deleted the patch-1 branch March 22, 2017 12:42
@ncopa
Copy link
Owner

ncopa commented Mar 22, 2017

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants