Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adjust-agolgeocoder-response-parse): convert to json only if response typeof is string #361

Conversation

juliano-aiqfome
Copy link
Contributor

@juliano-aiqfome juliano-aiqfome commented Nov 12, 2024

convert agolgeocoder response to json only if response typeof is string, to prevent exceptions.
Closes #360

@nchaulet
Copy link
Owner

Thanks for the contribution, I will publish a new version with your fix

@nchaulet nchaulet merged commit 001b8b1 into nchaulet:main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agolgeocoder crashing application when using invalid client and secret key instead of throwing exception
2 participants