handle empty array being returned by locationiq#211
Merged
nchaulet merged 2 commits intonchaulet:masterfrom Apr 9, 2017
Merged
handle empty array being returned by locationiq#211nchaulet merged 2 commits intonchaulet:masterfrom
nchaulet merged 2 commits intonchaulet:masterfrom
Conversation
Owner
|
Thanks for the PR. Could you fix the tests before I merge ? https://travis-ci.org/nchaulet/node-geocoder/jobs/209928920 |
Author
|
Tests should be fixed now. |
Owner
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have been using this library, I noticed responseData.map errors out on empty arrays returned by locationiq. This code is to handle that error.