Skip to content

Conversation

@karsten-adot
Copy link
Contributor

This PR makes the following changes:

  • Destroying cluser even if security group is missing (for example in case of ungraceful stop during a previous destroy)

I tested this PR by hand and against incomplete cluster (missing security group)

@nchammas
Copy link
Owner

Hi @karsten-adot and thank you for this fix. I took the liberty of simplifying it a bit given the recent changes we made in #378.

Overall, the code to manage security groups could use a more significant refactoring, but this fix is still helpful.

@nchammas nchammas merged commit 3cce613 into nchammas:master Dec 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants