XMPや信ぴょう性チェック対応 #29
Merged
XMPや信ぴょう性チェック対応 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangSungChul
commented
Jun 21, 2023
src/ios/CameraViewController.swift
Outdated
| @@ -587,12 +601,25 @@ extension CameraViewController: AVCapturePhotoCaptureDelegate { | |||
| let data = resizedImage!.jpegData(compressionQuality: 1.0) | |||
| if let jpegData = data { | |||
| // let base64String = jpegData.base64EncodedString(options: .lineLength64Characters) | |||
| guard let photoInfo = photoInfo else { return } | |||
| guard let imageDataEmbedMetaData = ElectronicBlackBoardManager.createImageEmbeddedMetaData(from: jpegData, photoInfo: photoInfo,imageDescription: "test image",model: model(),software: "TPR2") else { | |||
There was a problem hiding this comment.
imageDescription、softwareの確認が必要
残件
|
こちらは何を入れたら良いか不明ということでしょうか？ |
はい、１つ上にその箇所についてコメントしております。 |
|
@JangSungChul
softwareはプラグイン外部から指定できるようにしたいです。 |
|
@karuru6225 こちらPlugin側修正＆動作確認しました。
|
|
@JangSungChul 今の使い方は |
Feature/xmp info kotlin
…oard isNeedBlackBoardとblackboardViewPriorityのnull対応
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
https://github.com/ncdcdev/KuiManagementSystem/issues/2547
変更内容
確認したこと
スクリーンショット
補足事項