Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#551 Adds Docker support #552

Merged
merged 1 commit into from
Oct 15, 2019
Merged

#551 Adds Docker support #552

merged 1 commit into from
Oct 15, 2019

Conversation

duck-nukem
Copy link
Contributor

👋 this is the proposed Dockerfile - unfortunately couldn't use an alpine based image, this is the second smallest I could find.

Not sure if I can include changes for the wiki, but this should be the way of installing & running ScoutSuite with Docker:

Install

  1. clone the repository, and cd to the dir
  2. docker build -t scoutsuite:latest .

Run

docker run --rm -t \
-v /Users/me/.aws:/root/.aws:ro \
-v "$(pwd)/results:/opt/scoutsuite-report" \
scoutsuite:latest \
aws

If you'd like to add further clarification to these commands, it will:

  • run the image we just built with the tty flag, and the container will be removed once it finishes
  • will create a read-only volume to /Users/me/.aws (where /Users/me should be changed to the home directory of whoever runs it) so the aws creds are available from within the container.
  • will create another volume to $PWD/results so the generated report is accessible from the host
  • finally (after scoutsuite:latest) you just pass in arguments as you normally would to the script itself

@x4v13r64
Copy link
Collaborator

@thommor could you have a look please?

Copy link
Contributor

@thommor thommor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Dockerfile looks fine to me.

@j4v One of the tests is failing but I cant see this being caused by the Dockerfile, can you confirm?

FAIL: test_composite_resource (test-resources.TestResources)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/nccgroup/ScoutSuite/tests/test-resources.py", line 55, in test_composite_resource
    assert (expected_json == actual_json)

The wiki will need updating

@x4v13r64
Copy link
Collaborator

x4v13r64 commented Oct 15, 2019

@j4v One of the tests is failing but I cant see this being caused by the Dockerfile, can you confirm?

re-ran the tests and it went fine - for some reason builds sometime fail...

The wiki will need updating

https://github.com/nccgroup/ScoutSuite/wiki/Docker-Image

@x4v13r64 x4v13r64 merged commit e46afdb into nccgroup:develop Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants