Refactoring/gcp/gce

[Remi05]

Migrated Google Compute Engine to the new architecture. Also adds support for filtering GCE Instances by Zone and GCE Subnetworks by Region.

[codecov-io]

Codecov Report

Merging #319 into develop will increase coverage by 0.23%.
The diff coverage is 28.3%.

@@             Coverage Diff             @@
##           develop     #319      +/-   ##
===========================================
+ Coverage    33.83%   34.06%   +0.23%     
===========================================
  Files          179      189      +10     
  Lines         6071     6246     +175     
===========================================
+ Hits          2054     2128      +74     
- Misses        4017     4118     +101

Impacted Files	Coverage Δ
ScoutSuite/providers/gcp/resources/resources.py	44.44% <ø> (ø)	⬆️
ScoutSuite/providers/gcp/provider.py	12.19% <0%> (-0.63%)	⬇️
...coutSuite/providers/gcp/resources/gce/firewalls.py	14.89% <14.89%> (ø)
...utSuite/providers/gcp/resources/gce/subnetworks.py	21.73% <21.73%> (ø)
...coutSuite/providers/gcp/resources/gce/instances.py	26% <26%> (ø)
ScoutSuite/providers/gcp/facade/gce.py	26.66% <26.66%> (ø)
ScoutSuite/providers/gcp/resources/gce/networks.py	26.92% <26.92%> (ø)
...coutSuite/providers/gcp/resources/gce/snapshots.py	29.16% <29.16%> (ø)
ScoutSuite/providers/gcp/resources/gce/disks.py	33.33% <33.33%> (ø)
...uite/providers/gcp/resources/gce/instance_disks.py	36.36% <36.36%> (ø)
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972de88...0afb7a1. Read the comment docs.

[Aboisier]

Yayy

EDIT: well as long as you make sure everything works after merging with dev.

[Aboisier]

I'm also wondering if the Regions and Zones classes you defined couldn't be moved "up" (to providers/gcp/resources/, at the same level than GCPCompositeResources) in order to be "abstract" (like AWS Regions and VPCs) and be used for potential other GCP services. What do you think @Aboisier ?

Yup, looks like that would make sense! Ì haven't worked with GCP enough to know if there are other services which use regions. I'm guessing there are.

[Remi05]

I'm also wondering if the Regions and Zones classes you defined couldn't be moved "up" (to providers/gcp/resources/, at the same level than GCPCompositeResources) in order to be "abstract" (like AWS Regions and VPCs) and be used for potential other GCP services. What do you think @Aboisier ?

Yup, looks like that would make sense! Ì haven't worked with GCP enough to know if there are other services which use regions. I'm guessing there are.

I tried to do that at first but it caused a lot of issues, it's a bit different than AWS' VPC and Region. Anyway, the Regions and Zones are currently only used in GCE's API (to fetch regions and zones, we use the Compute Engine client).