Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/gcp/cloudstorage #304

Merged
merged 29 commits into from
Apr 12, 2019
Merged

Refactoring/gcp/cloudstorage #304

merged 29 commits into from
Apr 12, 2019

Conversation

Remi05
Copy link
Contributor

@Remi05 Remi05 commented Apr 4, 2019

Migrated GCP Cloud Storage to the new architecture.

@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #304 into develop will increase coverage by 0.77%.
The diff coverage is 38.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
+ Coverage    34.06%   34.84%   +0.77%     
===========================================
  Files          189      188       -1     
  Lines         6246     6015     -231     
===========================================
- Hits          2128     2096      -32     
+ Misses        4118     3919     -199
Impacted Files Coverage Δ
...te/providers/gcp/resources/cloudstorage/service.py 100% <100%> (ø)
...te/providers/gcp/resources/cloudstorage/buckets.py 25% <25%> (ø)
ScoutSuite/providers/gcp/facade/cloudstorage.py 46.66% <46.66%> (ø)
ScoutSuite/providers/gcp/configs/services.py 50% <50%> (ø) ⬆️
ScoutSuite/providers/gcp/facade/gcp.py 50% <50%> (ø) ⬆️
ScoutSuite/providers/base/configs/threads.py
ScoutSuite/providers/gcp/configs/base.py
ScoutSuite/providers/base/configs/base.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8e4f6...e4f3323. Read the comment docs.

@Aboisier Aboisier mentioned this pull request Apr 4, 2019
53 tasks
@vifor2 vifor2 added the component-provider-gcp Affects GCP provider label Apr 4, 2019
@vifor2 vifor2 modified the milestone: Iteration #6 Apr 4, 2019
Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I just left a few comments.

@vifor2 vifor2 requested review from x4v13r64 and Aboisier April 7, 2019 02:12
Co-Authored-By: Remi05 <remi_pelletier_6@hotmail.com>
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I left a few suggestions.

@Remi05 Remi05 requested review from misg and Aboisier and removed request for misg April 8, 2019 18:06
@Remi05
Copy link
Contributor Author

Remi05 commented Apr 8, 2019

I changed a few things regarding fetching of the IAM policy and the logging config so the remaining comments don't really apply anymore. Let me now what you think!

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments but looks good.

@Remi05
Copy link
Contributor Author

Remi05 commented Apr 12, 2019

Should be ready to merge, but I need to re-test it to make sure. I'm having problems with my GCP account and can't create new resources at the moment. I'll take care of it as soon as the issue with my GCP account gets resolved!

EDIT: Problem fixed!

@Remi05 Remi05 merged commit d3657d0 into develop Apr 12, 2019
@Remi05 Remi05 deleted the refactoring/gcp/cloudstorage branch April 12, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants