-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/gcp/cloudstorage #304
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #304 +/- ##
===========================================
+ Coverage 34.06% 34.84% +0.77%
===========================================
Files 189 188 -1
Lines 6246 6015 -231
===========================================
- Hits 2128 2096 -32
+ Misses 4118 3919 -199
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I just left a few comments.
Co-Authored-By: Remi05 <remi_pelletier_6@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I left a few suggestions.
ScoutSuite/providers/gcp/rules/findings/cloudstorage-bucket-no-logging.json
Show resolved
Hide resolved
ScoutSuite/providers/gcp/rules/findings/cloudstorage-bucket-no-logging.json
Show resolved
Hide resolved
I changed a few things regarding fetching of the IAM policy and the logging config so the remaining comments don't really apply anymore. Let me now what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments but looks good.
Should be ready to merge, but I need to re-test it to make sure. I'm having problems with my GCP account and can't create new resources at the moment. I'll take care of it as soon as the issue with my GCP account gets resolved! EDIT: Problem fixed! |
Migrated GCP Cloud Storage to the new architecture.