Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/kms #280

Merged
merged 6 commits into from
Mar 25, 2019
Merged

Refactoring/aws/kms #280

merged 6 commits into from
Mar 25, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 24, 2019

This PR aims to migrate private AWS KMS service to the new architecture, as part of #183. Please look at the proprietary PR as well.

@misg misg requested review from Aboisier, x4v13r64 and Remi05 March 24, 2019 16:28
@misg misg self-assigned this Mar 24, 2019
@misg misg added this to the Iteration #5 milestone Mar 24, 2019
@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #280 into refactoring/resource-configs will decrease coverage by <.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #280      +/-   ##
================================================================
- Coverage                         32.52%   32.51%   -0.01%     
================================================================
  Files                               149      149              
  Lines                              5617     5612       -5     
================================================================
- Hits                               1827     1825       -2     
+ Misses                             3790     3787       -3
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/facade.py 44.28% <25%> (-1.31%) ⬇️
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️
ScoutSuite/output/js.py 25% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f416c1a...d8373e0. Read the comment docs.

@misg misg merged commit 7828129 into refactoring/resource-configs Mar 25, 2019
@misg misg deleted the refactoring/aws/kms branch March 25, 2019 16:23
@Aboisier Aboisier mentioned this pull request Mar 25, 2019
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants