Refactoring/aws/dynamodb #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aboisier
added
component-provider-aws
53 tasks
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #274 +/- ##
================================================================
- Coverage 31% 30.99% -0.02%
================================================================
Files 130 130
Lines 5632 5634 +2
================================================================
Hits 1746 1746
- Misses 3886 3888 +2
Continue to review full report at Codecov.
|
vifor2
reviewed
Mar 22, 2019
| from ScoutSuite.providers.aws.services.kms_private import KMSConfig | ||
| except ImportError: | ||
| ConfigConfig = None | ||
| DynamoDBConfig = None | ||
| Config = None |
vifor2
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates DynamoDB to the new architecture, see #183 . This is part of a proprietary feature, please also review the proprietary PR.
Interesting stuff:
The get for one table requires 3 API calls (getting the table info, the manual backups info and the continuous backups). I batched the requests instead of just parallelizing all the requests. This will mitigate the risk of being throttled.EDIT: The batching was actually reverted. We realized the number of concurrent requests was already limited by the number of threads, so this became superfluous.