Refactoring/aws/rds

[Aboisier]

This PR migrates RDS to the new architecture, see #183 .

Here are some side effects of the migration:

• The data structure now contains vpcs even if there are no resources.

[codecov-io]

Codecov Report

Merging #271 into refactoring/resource-configs will increase coverage by 0.31%.
The diff coverage is 37.57%.

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #271      +/-   ##
================================================================
+ Coverage                          30.9%   31.22%   +0.31%     
================================================================
  Files                               130      137       +7     
  Lines                              5633     5727      +94     
================================================================
+ Hits                               1741     1788      +47     
- Misses                             3892     3939      +47

Impacted Files	Coverage Δ
...coutSuite/providers/aws/resources/rds/snapshots.py	25% <25%> (ø)
ScoutSuite/providers/aws/facade/rds.py	30% <30%> (ø)
ScoutSuite/providers/aws/facade/facade.py	35.59% <33.33%> (-0.13%)	⬇️
...ite/providers/aws/resources/rds/parametergroups.py	35.71% <35.71%> (ø)
...coutSuite/providers/aws/resources/rds/instances.py	40% <40%> (ø)
...Suite/providers/aws/resources/rds/securitygroup.py	41.66% <41.66%> (ø)
ScoutSuite/providers/aws/resources/rds/service.py	47.05% <47.05%> (ø)
...tSuite/providers/aws/resources/rds/subnetgroups.py	50% <50%> (ø)
ScoutSuite/providers/aws/configs/services.py	49.18% <50%> (ø)	⬆️
ScoutSuite/providers/aws/resources/rds/vpcs.py	87.5% <87.5%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c542ca9...bfd239b. Read the comment docs.

[codecov-io]

Codecov Report

Merging #271 into refactoring/resource-configs will increase coverage by 0.32%.
The diff coverage is 37.79%.

@@                       Coverage Diff                       @@
##           refactoring/resource-configs    #271      +/-   ##
===============================================================
+ Coverage                         30.98%   31.3%   +0.32%     
===============================================================
  Files                               130     137       +7     
  Lines                              5641    5727      +86     
===============================================================
+ Hits                               1748    1793      +45     
- Misses                             3893    3934      +41

Impacted Files	Coverage Δ
...coutSuite/providers/aws/resources/rds/snapshots.py	25% <25%> (ø)
ScoutSuite/providers/aws/facade/rds.py	30% <30%> (ø)
...ite/providers/aws/resources/rds/parametergroups.py	35.71% <35.71%> (ø)
...coutSuite/providers/aws/resources/rds/instances.py	40% <40%> (ø)
...uite/providers/aws/resources/rds/securitygroups.py	41.66% <41.66%> (ø)
ScoutSuite/providers/aws/resources/rds/service.py	47.05% <47.05%> (ø)
...tSuite/providers/aws/resources/rds/subnetgroups.py	50% <50%> (ø)
ScoutSuite/providers/aws/facade/facade.py	44.06% <50%> (+0.2%)	⬆️
ScoutSuite/providers/aws/configs/services.py	49.18% <50%> (ø)	⬆️
ScoutSuite/providers/aws/resources/rds/vpcs.py	87.5% <87.5%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e95ff...1205930. Read the comment docs.

[vifor2]

Dayum you're a machine! Btw I think this is perfectly fine as is, but if you ever know how to narrow down the type of error expected I think PyCharm would appreciate. I always get warnings of Exception clause too broad when using lines such as the line 84 of rds.py : except Exception as e:

[misg]

A* 😍 .

[x4v13r64]

@Aboisier as part of this PR could you please confirm/resolve the following open issue #14?