Refactoring/aws/s3

[Aboisier]

This PR migrates S3 to the new architecture, see #183 .

What changed (apart from like changing the architecture):

• I removed a property named logging_stuff which contained what I identified as both redundant and irrelevant data.
• About 100 lines of dead code were removed

[vifor2]

[codecov-io]

Codecov Report

Merging #270 into refactoring/resource-configs will increase coverage by 0.58%.
The diff coverage is 20.83%.

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #270      +/-   ##
================================================================
+ Coverage                          30.9%   31.48%   +0.58%     
================================================================
  Files                               130      131       +1     
  Lines                              5633     5545      -88     
================================================================
+ Hits                               1741     1746       +5     
+ Misses                             3892     3799      -93

Impacted Files	Coverage Δ
ScoutSuite/providers/aws/provider.py	9.74% <0%> (-0.02%)	⬇️
ScoutSuite/providers/aws/facade/s3.py	15.94% <15.94%> (ø)
ScoutSuite/providers/aws/facade/facade.py	35.59% <33.33%> (-0.13%)	⬇️
ScoutSuite/providers/aws/resources/s3/service.py	47.82% <47.82%> (ø)
ScoutSuite/providers/aws/configs/services.py	49.18% <50%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c542ca9...9c86f38. Read the comment docs.

[codecov-io]

Codecov Report

Merging #270 into refactoring/resource-configs will increase coverage by 0.54%.
The diff coverage is 21.42%.

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #270      +/-   ##
================================================================
+ Coverage                         32.81%   33.35%   +0.54%     
================================================================
  Files                               157      157              
  Lines                              5702     5606      -96     
================================================================
- Hits                               1871     1870       -1     
+ Misses                             3831     3736      -95

Impacted Files	Coverage Δ
ScoutSuite/providers/aws/provider.py	9.82% <0%> (-0.05%)	⬇️
ScoutSuite/providers/aws/facade/s3.py	15.94% <15.94%> (ø)
ScoutSuite/providers/aws/resources/s3/service.py	47.82% <47.82%> (ø)
ScoutSuite/providers/aws/configs/services.py	50% <50%> (ø)	⬆️
ScoutSuite/providers/aws/facade/facade.py	44.73% <66.66%> (+0.9%)	⬆️
ScoutSuite/providers/aws/configs/base.py
.../providers/aws/resources/cloudformation/service.py	27.45% <0%> (+0.62%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d719e3...3d95dee. Read the comment docs.

[misg]

Great job! 💯 I just left some comments about details and concurrency.