Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/route53 #267

Merged
merged 8 commits into from
Mar 25, 2019
Merged

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 20, 2019

This PR aims to migrate AWS Route53 service to the new architecture, as part of #183.
Please note that I removed hosted_zones resources which were not used anywhere and got rid of route53domains service which was a duplicate of route53 service (hence the method merge_route53_and_route53domains in aws/provider.py).

@Aboisier Aboisier mentioned this pull request Mar 20, 2019
53 tasks
@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #267 into refactoring/resource-configs will increase coverage by 0.09%.
The diff coverage is 63.33%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           refactoring/resource-configs    #267      +/-   ##
===============================================================
+ Coverage                         32.51%   32.6%   +0.09%     
===============================================================
  Files                               149     150       +1     
  Lines                              5619    5603      -16     
===============================================================
  Hits                               1827    1827              
+ Misses                             3792    3776      -16
Impacted Files Coverage Δ
ScoutSuite/providers/aws/provider.py 9.89% <ø> (-0.09%) ⬇️
ScoutSuite/providers/aws/configs/services.py 50% <50%> (+0.81%) ⬆️
...utSuite/providers/aws/resources/route53/service.py 52.94% <52.94%> (ø)
ScoutSuite/providers/aws/facade/route53.py 80% <80%> (ø)
ScoutSuite/providers/aws/facade/facade.py 43.66% <83.33%> (-0.63%) ⬇️
ScoutSuite/output/js.py 25% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7828129...e0a6b4a. Read the comment docs.

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 💯

@x4v13r64
Copy link
Collaborator

@misg as part of this PR could you please confirm/resolve the following open issues:
#13
#163

@misg misg merged commit e1732da into refactoring/resource-configs Mar 25, 2019
@misg misg deleted the refactoring/aws/route53 branch March 25, 2019 21:09
@benghaun benghaun mentioned this pull request Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants