-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/route53 #267
Conversation
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #267 +/- ##
===============================================================
+ Coverage 32.51% 32.6% +0.09%
===============================================================
Files 149 150 +1
Lines 5619 5603 -16
===============================================================
Hits 1827 1827
+ Misses 3792 3776 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 💯
This PR aims to migrate AWS Route53 service to the new architecture, as part of #183.
Please note that I removed
hosted_zones
resources which were not used anywhere and got rid ofroute53domains
service which was a duplicate ofroute53
service (hence the methodmerge_route53_and_route53domains
inaws/provider.py
).