-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/sns #265
Refactoring/aws/sns #265
Conversation
# Conflicts: # ScoutSuite/providers/aws/facade/facade.py
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #265 +/- ##
================================================================
+ Coverage 30.98% 31.23% +0.24%
================================================================
Files 130 141 +11
Lines 5641 5869 +228
================================================================
+ Hits 1748 1833 +85
- Misses 3893 4036 +143
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR aims to migrate AWS SNS service to the new architecture, as part of #183.
Please note that I removed
subscriptions
resources from themetadata.json
file because they are already included in theirtopics
resources (and displayed as so in the report, see above picture).