-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/iam #264
Refactoring/aws/iam #264
Conversation
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #264 +/- ##
================================================================
+ Coverage 32.6% 32.81% +0.21%
================================================================
Files 150 157 +7
Lines 5610 5701 +91
================================================================
+ Hits 1829 1871 +42
- Misses 3781 3830 +49
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 💯 💯
EDIT: Except for the part where the tests now fail May need to merge @misg's refactor of ELBv2 into this branch to solve the issue :
ImportError: No module named 'ScoutSuite.providers.aws.services.elbv2'
It was just a bad merge actually. :'( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow amazing work there, I can only imagine how tricky this could have been! I mainly left suggestions about concurrency. 😉
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
This PR migrates the IAM service to the new architecture, see #183 .
EDIT:
The resources count changed a bit because inline policies were included in the policies count. This did not make sense because, in the dropdown, you would see, Policies (17), (15 managed policies and 2 inline, for example), but the policies page would only show the managed policies.