Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/iam #264

Merged
merged 61 commits into from
Mar 25, 2019
Merged

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Mar 18, 2019

This PR migrates the IAM service to the new architecture, see #183 .

EDIT:
The resources count changed a bit because inline policies were included in the policies count. This did not make sense because, in the dropdown, you would see, Policies (17), (15 managed policies and 2 inline, for example), but the policies page would only show the managed policies.

@codecov-io
Copy link

codecov-io commented Mar 18, 2019

Codecov Report

Merging #264 into refactoring/resource-configs will increase coverage by 0.21%.
The diff coverage is 20.44%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #264      +/-   ##
================================================================
+ Coverage                          32.6%   32.81%   +0.21%     
================================================================
  Files                               150      157       +7     
  Lines                              5610     5701      +91     
================================================================
+ Hits                               1829     1871      +42     
- Misses                             3781     3830      +49
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/awslambda.py 80% <ø> (ø) ⬆️
ScoutSuite/providers/aws/facade/cloudtrail.py 45.45% <0%> (ø) ⬆️
ScoutSuite/providers/aws/facade/directconnect.py 71.42% <0%> (ø) ⬆️
ScoutSuite/providers/aws/facade/elasticache.py 39.53% <0%> (ø) ⬆️
ScoutSuite/providers/aws/facade/cloudformation.py 35% <0%> (ø) ⬆️
ScoutSuite/providers/aws/provider.py 9.82% <0%> (-0.07%) ⬇️
ScoutSuite/providers/aws/facade/emr.py 40% <0%> (ø) ⬆️
ScoutSuite/providers/aws/facade/efs.py 27.77% <0%> (ø) ⬆️
ScoutSuite/providers/aws/facade/ec2.py 31.34% <0%> (ø) ⬆️
ScoutSuite/providers/aws/facade/iam.py 12.41% <12.41%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1732da...632dcf1. Read the comment docs.

@Aboisier Aboisier mentioned this pull request Mar 18, 2019
53 tasks
Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

EDIT: Except for the part where the tests now fail image May need to merge @misg's refactor of ELBv2 into this branch to solve the issue : ImportError: No module named 'ScoutSuite.providers.aws.services.elbv2'

@Aboisier
Copy link
Contributor Author

💯 💯 💯
Thanks for the review!

EDIT: Except for the part where the tests now fail image May need to merge @misg's refactor of ELBv2 into this branch to solve the issue : ImportError: No module named 'ScoutSuite.providers.aws.services.elbv2'

It was just a bad merge actually. :'(

Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow amazing work there, I can only imagine how tricky this could have been! I mainly left suggestions about concurrency. 😉

misg and others added 4 commits March 21, 2019 19:29
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
@Aboisier Aboisier merged commit 342e9a3 into refactoring/resource-configs Mar 25, 2019
@Aboisier Aboisier deleted the refactoring/aws/iam branch March 25, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants