Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/redshift #261

Merged
merged 10 commits into from
Mar 18, 2019
Merged

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 17, 2019

This PR aims to migrate AWS Redshift service to the new architecture, as part of #183.

@codecov-io
Copy link

codecov-io commented Mar 17, 2019

Codecov Report

Merging #261 into refactoring/resource-configs will increase coverage by 0.23%.
The diff coverage is 48.93%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #261      +/-   ##
================================================================
+ Coverage                         30.49%   30.72%   +0.23%     
================================================================
  Files                               120      126       +6     
  Lines                              5542     5601      +59     
================================================================
+ Hits                               1690     1721      +31     
- Misses                             3852     3880      +28
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/facade.py 35.84% <33.33%> (-1.41%) ⬇️
...Suite/providers/aws/resources/redshift/clusters.py 36.36% <36.36%> (ø)
.../aws/resources/redshift/cluster_security_groups.py 36.36% <36.36%> (ø)
...iders/aws/resources/redshift/cluster_parameters.py 40% <40%> (ø)
...aws/resources/redshift/cluster_parameter_groups.py 43.75% <43.75%> (ø)
ScoutSuite/providers/aws/facade/redshift.py 48.14% <48.14%> (ø)
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️
...coutSuite/providers/aws/resources/redshift/vpcs.py 83.33% <83.33%> (ø)
...tSuite/providers/aws/resources/redshift/service.py 87.5% <87.5%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5baa3d1...82a2c52. Read the comment docs.

@misg misg requested review from Aboisier, x4v13r64 and Remi05 March 17, 2019 23:57
@misg misg self-assigned this Mar 17, 2019
@misg misg added this to the Iteration #4 milestone Mar 17, 2019
@Aboisier Aboisier mentioned this pull request Mar 18, 2019
53 tasks
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Good stuff!

@misg misg merged commit 152a01b into refactoring/resource-configs Mar 18, 2019
@misg misg deleted the refactoring/aws/redshift branch March 18, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants