Refactoring/aws/elbv2

[misg]

This PR aims to migrate AWS ELBv2 service to the new architecture, as part of #183.
Please note that I removed the ssl_policies resources (defined in the metadata.json file) since they weren't used anywhere.

[codecov-io]

Codecov Report

Merging #259 into refactoring/resource-configs will increase coverage by 0.18%.
The diff coverage is 41.66%.

@@                       Coverage Diff                       @@
##           refactoring/resource-configs    #259      +/-   ##
===============================================================
+ Coverage                         30.72%   30.9%   +0.18%     
===============================================================
  Files                               126     130       +4     
  Lines                              5601    5633      +32     
===============================================================
+ Hits                               1721    1741      +20     
- Misses                             3880    3892      +12

Impacted Files	Coverage Δ
ScoutSuite/providers/aws/provider.py	9.76% <0%> (-0.41%)	⬇️
ScoutSuite/providers/aws/facade/facade.py	35.71% <33.33%> (-0.14%)	⬇️
...te/providers/aws/resources/elbv2/load_balancers.py	33.33% <33.33%> (ø)
...utSuite/providers/aws/resources/elbv2/listeners.py	33.33% <33.33%> (ø)
ScoutSuite/providers/aws/configs/services.py	49.18% <50%> (ø)	⬆️
ScoutSuite/providers/aws/facade/elbv2.py	52.17% <52.17%> (ø)
ScoutSuite/providers/aws/resources/elbv2/vpcs.py	83.33% <83.33%> (ø)
...coutSuite/providers/aws/resources/elbv2/service.py	83.33% <83.33%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152a01b...a2044e6. Read the comment docs.

[vifor2]

I apologize for the troubles this has caused you, stay strong! 💪

[Aboisier]

Wait what

[Aboisier]

I'm so confused what is this

[misg]

It's just a function that Vincent defined for his findings related to ELBv2, is only used by _add_security_group_data_to_elbv2 and was in aws/services/elbv2.py. So it wasn't really make sense to move it in aws/resources/elbv2/ directory, moving it to _add_security_group_data_to_elbv2 as a nested function where it is used makes more sense imho (at least now, waiting for a refactoring of all the post-processing logic).

[Aboisier]

I'm confused by the nested method though. But great work 💯