-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/emr #248
Refactoring/aws/emr #248
Conversation
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #248 +/- ##
================================================================
+ Coverage 29.96% 30.01% +0.05%
================================================================
Files 111 112 +1
Lines 5527 5557 +30
================================================================
+ Hits 1656 1668 +12
- Misses 3871 3889 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As each day passes by, the cataclysm of the great merging between the forces of the refactoring branch and the develop branch nears!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🎆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(You can batch these 4 suggestions into one single commit, using the new feature from the Files changed
tab, I think)
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
This PR migrated the EMR service to the new architecture, see #183 . There was a hack, caused by an API limitation. I kept it, since refactoring it is a bit out of the scope of this story.