Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/emr #248

Merged
merged 14 commits into from
Mar 13, 2019
Merged

Conversation

Aboisier
Copy link
Contributor

This PR migrated the EMR service to the new architecture, see #183 . There was a hack, caused by an API limitation. I kept it, since refactoring it is a bit out of the scope of this story.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #248 into refactoring/resource-configs will increase coverage by 0.05%.
The diff coverage is 42.85%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #248      +/-   ##
================================================================
+ Coverage                         29.96%   30.01%   +0.05%     
================================================================
  Files                               111      112       +1     
  Lines                              5527     5557      +30     
================================================================
+ Hits                               1656     1668      +12     
- Misses                             3871     3889      +18
Impacted Files Coverage Δ
ScoutSuite/providers/aws/resources/vpcs.py 35.29% <ø> (ø) ⬆️
ScoutSuite/providers/aws/provider.py 10.29% <0%> (ø) ⬆️
ScoutSuite/providers/aws/facade/facade.py 37.25% <33.33%> (-0.25%) ⬇️
ScoutSuite/providers/aws/facade/emr.py 40% <40%> (ø)
ScoutSuite/providers/aws/resources/emr/service.py 46.42% <46.42%> (ø)
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd033d...a5f3dca. Read the comment docs.

Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As each day passes by, the cataclysm of the great merging between the forces of the refactoring branch and the develop branch nears!

@Aboisier Aboisier changed the base branch from refactoring/aws/elasticache to refactoring/resource-configs March 13, 2019 20:39
Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎆

Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(You can batch these 4 suggestions into one single commit, using the new feature from the Files changed tab, I think)

misg and others added 2 commits March 13, 2019 17:04
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
@Aboisier Aboisier requested a review from misg March 13, 2019 21:07
@Aboisier Aboisier merged commit fa3b309 into refactoring/resource-configs Mar 13, 2019
@Aboisier Aboisier deleted the refactoring/aws/emr branch March 13, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants