Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/azure/securitycenter #243

Merged
merged 9 commits into from
Mar 13, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 11, 2019

This PR aims to migrate Azure Security Center service to the new architecture, as part of #183.

@misg misg requested review from Aboisier, x4v13r64 and Remi05 March 11, 2019 16:35
@misg misg self-assigned this Mar 11, 2019
@misg misg added this to the Iteration #4 milestone Mar 11, 2019
@Aboisier Aboisier mentioned this pull request Mar 11, 2019
53 tasks
@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #243 into refactoring/resource-configs will increase coverage by 0.2%.
The diff coverage is 43.05%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           refactoring/resource-configs     #243     +/-   ##
===============================================================
+ Coverage                         30.34%   30.55%   +0.2%     
===============================================================
  Files                               118      122      +4     
  Lines                              5612     5649     +37     
===============================================================
+ Hits                               1703     1726     +23     
- Misses                             3909     3923     +14
Impacted Files Coverage Δ
...zure/resources/securitycenter/security_contacts.py 27.77% <27.77%> (ø)
...oviders/azure/resources/securitycenter/pricings.py 35.71% <35.71%> (ø)
...urces/securitycenter/auto_provisioning_settings.py 35.71% <35.71%> (ø)
ScoutSuite/providers/azure/configs/services.py 53.06% <50%> (ø) ⬆️
.../azure/resources/securitycenter/security_center.py 61.53% <61.53%> (ø)
...coutSuite/providers/azure/facade/securitycenter.py 63.63% <63.63%> (ø)
...utSuite/providers/azure/services/securitycenter.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b998c...3df66ff. Read the comment docs.

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll eventually all agree on the same conventions. haha

@misg misg force-pushed the refactoring/azure/securitycenter branch from 19f6cd7 to 2dca539 Compare March 11, 2019 18:33
@misg misg merged commit 126937c into refactoring/resource-configs Mar 13, 2019
@misg misg deleted the refactoring/azure/securitycenter branch March 13, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants